gh-129248: Filter out the iOS log prefix from testbed runner output. #129252
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit e6c7195 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Misc/NEWS.d/next/Tools-Demos/2025-01-24-14-49-40.gh-issue-129248.JAapG2.rst
Show resolved
Hide resolved
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2025
…tput. (pythonGH-129252) Filter out the iOS log prefix from testbed runner output. (cherry picked from commit a58083811a51764c47fbb7cbd67e87e1124d53e8) Co-authored-by: Russell Keith-Magee <[email protected]>
|
GH-129283 is a backport of this pull request to the 3.13 branch. |
freakboy3742
added a commit
that referenced
this pull request
Jan 25, 2025
…utput. (GH-129252) (#129283) Filter out the iOS log prefix from testbed runner output. (cherry picked from commit a580838) Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the iOS test runner to strip out the log prefix inserted by the Apple system log.
iOS test logs are gathered by streaming the Apple System log looking for log items from the test process. These log prefixes look like:
The existence of these prefixes was preventing the buildbots from parsing log output to discover test failures. Since the prefix doesn't actually help diagnose issues with the Python test suite, this PR strips out the prefix. This matches what the Android test runner does with ADB log prefixes. It doesn't strip the prefix from the iOS setup/teardown code (the ObjC code that instantiates the XUnit test case, which might be helpful in a diagnostic context, but won't interfere with the Python operation
The acid test for this fix is a test failing and being correctly parsed by the buildbot; that's a little difficult to manufacture, though. For review purposes, you can inspect the test log for the buildbot to see that it matches the test output from other platforms; at which point the buildbot log parser should work as it does on any other platform.
Fixes #129248.