Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126022: make license.rst consistent with LICENSE #128516

Merged
merged 4 commits into from
Jan 25, 2025
Merged

Conversation

partev
Copy link
Contributor

@partev partev commented Jan 5, 2025

following on @gvanrossum 's advice I made license.rst consistent with LICENSE file.


📚 Documentation preview 📚: https://cpython-previews--128516.org.readthedocs.build/

Copy link
Contributor

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions.

Doc/license.rst Show resolved Hide resolved
Doc/license.rst Show resolved Hide resolved
Doc/license.rst Show resolved Hide resolved
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have manually reviewed that all the changes in this PR now reflect the text of LICENSE. (I haven't done the opposite, but Hugo already did that).

Therefore IMO it's ready to be merged. @hugovk if you agree, just merge it! Then for the parent issue we can just apply whatever we decide to do about Zope to both files.

@@ -205,7 +208,7 @@ CNRI LICENSE AGREEMENT FOR PYTHON 1.6.1
Agreement. This Agreement together with Python 1.6.1 may be located on the
internet using the following unique, persistent identifier (known as a handle):
1895.22/1013. This Agreement may also be obtained from a proxy server on the
internet using the following URL: http://hdl.handle.net/1895.22/1013."
internet using the following URL: http://hdl.handle.net/1895.22/1013".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[sic] -- the missing quote is also missing in LICENSE. :-)

@hugovk
Copy link
Member

hugovk commented Jan 25, 2025

Thanks all, let's merge!

@hugovk hugovk merged commit 9682a88 into python:main Jan 25, 2025
29 checks passed
@hugovk hugovk added awaiting merge needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 25, 2025
@miss-islington-app
Copy link

Thanks @partev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @partev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @partev and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9682a88683367f79c5b626b2ad809d569e37f602 3.12

@miss-islington-app
Copy link

Sorry, @partev and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9682a88683367f79c5b626b2ad809d569e37f602 3.13

hugovk pushed a commit to hugovk/cpython that referenced this pull request Jan 25, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 25, 2025

GH-129290 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 25, 2025
Comment on lines +279 to 280
ZERO-CLAUSE BSD LICENSE FOR CODE IN THE PYTHON DOCUMENTATION
----------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll include this in the backports and do a quick followup to fix this in main :)

Suggested change
ZERO-CLAUSE BSD LICENSE FOR CODE IN THE PYTHON DOCUMENTATION
----------------------------------------------------------------------
ZERO-CLAUSE BSD LICENSE FOR CODE IN THE PYTHON DOCUMENTATION
------------------------------------------------------------

@bedevere-app
Copy link

bedevere-app bot commented Jan 25, 2025

GH-129291 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 25, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull request Jan 25, 2025
@partev partev deleted the patch-4 branch January 25, 2025 17:39
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, sorry I didn't see these before merging.

Doc/license.rst Show resolved Hide resolved
Doc/license.rst Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants