gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings, and internal test warnings that are now logged

[graingert]

• Issue: configure warnings as errors in the test suite #128770

[graingert]

@hugovk can I get a run on the buildbots for this PR?

[hugovk]

Certainly!

Let's check if you can do it yourself: either apply one of the test-with-buildbots or test-with-refleak-buildbots labels, or add a comment like ! buildbot optional-regex (but no space between exclamation mark and buildbot) to run a subset.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @graingert for commit c06c3db 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @graingert for commit 7123093 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[graingert]

@hugovk do you know where I can see the status?

[hugovk]

You can click the "Details" links in the status checks:

Some of those failing ones were already failing for previous builds, so aren't necessarily caused by this PR.

[graingert]

You can click the "Details" links in the status checks:

Some of those failing ones were already failing for previous builds, so aren't necessarily caused by this PR.

Ah those hadn't shown up yet

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @graingert for commit 36bba4e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[picnixz]

I'll let Hugo have a look as well!

[hugovk]

About the licence, in general this seems fine to use/modify the code and credit it, but maybe it should be mentioned in https://docs.python.org/3/license.html instead? Let's ask if @encukou knows.

[encukou]

That is where we put the licences (see e.g. https://docs.python.org/3/license.html#test-epoll)
But I don't know much about incorporating code where not all authors signed the CLA.

It seems caplog is derived from pytest-catchlog which has a different copyright section.

[graingert]

how about if I just pare it down to the bare minimum for the tests to pass:

class LogCaptureHandler(logging.StreamHandler):
    def __init__(self):
        super().__init__(io.StringIO())
        self.records = []

    def emit(self, record) -> None:
        self.records.append(record)
        super().emit(record)

[graingert]

is the above small enough to not be a concern for copyright?

[graingert]

I'm having trouble with the new warnings introduced #129287