gh-129005: Avoid copy in _pyio.FileIO.readinto #129006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`os.read` allocated and filled a buffer by calling `read(2)`, than that data was copied into the user provied buffer. Read directly into the caller's buffer instead by using `os.readv`. `self.read()` was doing the closed and readable checks so move those into `readinto`
|
|
tomasr8
approved these changes
Jan 19, 2025
Misc/NEWS.d/next/Library/2025-01-18-15-29-08.gh-issue-129005.mM5dmV.rst
Outdated
Show resolved
Hide resolved
|
Thanks for the review @tomasr8 ! Going to close this PR while I work on #129205, then will make a new PR which uses that (See: #129005 (comment) for context if desired). Makes the same change simpler / no conditional around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.readallocated and filled a buffer by callingread(2), than that data was copied into the user provied buffer. Read directly into the caller's buffer instead by usingos.readv.self.read()was doing the closed and readable checks so move those intoreadintoPR of
readintofirst as it is a lot smaller diff than thereadallcode but has the coreos.read->os.readvchange. Inmainhow the buffer is expanded between_io(new_buffersize) and_pyio(inline inread()) should get lined up.