Remove unused DPRINTF in ceval.c

[chris-eibl]

Per encouragement from @Fidget-Spinner in #129113 (comment).

DPRINTF was introduced in 7e135a4, but is currently unused.

Alternatively, I can modify it to use frame->lltrace, since lltrace has been moved into the frame (#129113).

I think this is a skip news?

• Issue: A new tail-calling interpreter for significantly better interpreter performance #128563

[cpython-cla-bot]

All commit authors signed the Contributor License Agreement.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[chris-eibl]

PS: I've stumbled over the immediately following lines

    ; // dummy statement after a label, before a declaration
    uint16_t uopcode;

where I think the first can be removed and the second dedented?

[Fidget-Spinner]

This shouldn't be tied to the tail call issue, as it's an unrelated improvement. Otherwise everything LGTM. Thanks!. I'll just de-link it and approve it.

[Fidget-Spinner]

Woops forgot to submit the approval, but I did look through it before merging. Sorry!

[chris-eibl]

PS: I've stumbled over the immediately following lines

    ; // dummy statement after a label, before a declaration
    uint16_t uopcode;

where I think the first can be removed and the second dedented?

Is this worth a PR? If so, I'd happily create one. Most probably again a skip news and no issue needed?

[Fidget-Spinner]

I think that's used in the tier 2 interpreter?

[chris-eibl]

Those two lines are in global scope, so IMHO the ; does not serve any purpose (any longer).

Maybe that's a leftover, when those two lines were part of an #if, but I think ; can be safely removed and the other dedented. Doing so, ceval.c compiles fine for me.

Edited: please scratch that, that's part of _Py_TIER2, which I had not defined when compiling ceval.c :(

[chris-eibl]

Oh, sorry, my bad, I think now understand. That belongs to

// Tier 2 is also here!
enter_tier_two:

about 25 lines above, in case _Py_JIT is not defined. Was too hard too read for me with all the macro definitions in between :)

Sorry for the noise.