-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-129294: use winapi to determine win version before invoking cmd.exe #129295
base: main
Are you sure you want to change the base?
gh-129294: use winapi to determine win version before invoking cmd.exe #129295
Conversation
…before trying to create a process using cmd.exe ver"
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
@@ -110,7 +110,7 @@ | |||
|
|||
""" | |||
|
|||
__version__ = '1.0.9' | |||
__version__ = '1.0.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be updated?
__version__ = '1.0.10' | |
__version__ = '1.0.9' |
It was updated a couple of months ago in #122547, but the previous change was 10 years ago (b9f4fea), and there have been lots of updates in the past decade that didn't change it:
https://github.com/python/cpython/commits/main/Lib/platform.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the module __version__
attribute really still needed? I thought that these were obsolete. If kept, is the use defined anywhere in a manner that would say when to bump it?
The issue quoted existing code |
Improve platform module: use rtlGetVersion to determine win version before trying to use cmd.exe