gh-128421: make exception group methods thread safe #129298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kumaraditya303
commented
Jan 25, 2025
•
kumaraditya303
commented
- Issue: data races in frame inspection and tracebacks #128421
iritkatriel
reviewed
Jan 25, 2025
Objects/exceptions.c
Outdated
| return eg; | ||
| PyObject *stack[] = {self->msg, excs}; | ||
| size_t nargsf = 2 | PY_VECTORCALL_ARGUMENTS_OFFSET; | ||
| return PyObject_Vectorcall(PyExc_BaseExceptionGroup, stack, nargsf, NULL); |
There was a problem hiding this comment.
No, it was an unrelated optimization merged accidently into this, removed now.
There was a problem hiding this comment.
What here makes it thread safe then?
There was a problem hiding this comment.
What here makes it thread safe then?
Adding @critical_section using argument clinic makes it use critical section around function call which makes it thread safe.
kumaraditya303
commented
Jan 25, 2025
iritkatriel
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.