Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Manifest Group #235

Merged
merged 6 commits into from
Aug 19, 2022
Merged

Fix Manifest Group #235

merged 6 commits into from
Aug 19, 2022

Conversation

ericsnowcurrently
Copy link
Member

This addresses several of the problems noted in #234.

Notably:

  • disallow groups named "all"
  • disallow duplicate group names, even if in different included manifests
  • disallow benchmarks named "all"
  • disallow duplicate benchmark names
  • clean up the "list_groups" command
  • fix how group resolution falls back to the tags

@ericsnowcurrently ericsnowcurrently merged commit caf63ec into python:main Aug 19, 2022
@ericsnowcurrently ericsnowcurrently deleted the fix-manifest-included-resolver branch August 19, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ericsnowcurrently