use Option<bool> to windows apis

raphamorim · Jan 9, 2025 · aa9e906 · aa9e906
1 parent 5cd38e2
commit aa9e906
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/frontends/rioterm/src/router/window.rs b/frontends/rioterm/src/router/window.rs
@@ -76,17 +76,19 @@ pub fn create_window_builder(
     #[cfg(target_os = "windows")]
     {
         use rio_window::platform::windows::WindowAttributesExtWindows;
-        if !config.window.windows_with_undecorated_shadow {
+        if let Some(use_undecorated_shadow) =
+            config.window.windows_use_undecorated_shadow
+        {
             window_builder = window_builder
-                .with_undecorated_shadow(config.window.windows_with_undecorated_shadow);
+                .with_undecorated_shadow(config.window.use_undecorated_shadow);
         }
 
-        if let Some(with_no_redirection_bitmap) =
-            config.window.windows_with_no_redirection_bitmap
+        if let Some(use_no_redirection_bitmap) =
+            config.window.windows_use_no_redirection_bitmap
         {
             // This sets WS_EX_NOREDIRECTIONBITMAP.
             window_builder = window_builder
-                .with_no_redirection_bitmap(config.window.with_no_redirection_bitmap);
+                .with_no_redirection_bitmap(config.window.use_no_redirection_bitmap);
         }
     }
 

diff --git a/rio-backend/src/config/window.rs b/rio-backend/src/config/window.rs
@@ -75,9 +75,9 @@ pub struct Window {
     pub initial_title: Option<String>,
     #[serde(
         rename = "windows-use-undecorated-shadow",
-        default = "default_bool_true"
+        default = "Option::default"
     )]
-    pub windows_use_undecorated_shadow: bool,
+    pub windows_use_undecorated_shadow: Option<bool>,
     #[serde(
         rename = "windows-use-no-redirection-bitmap",
         default = "Option::default"
@@ -100,7 +100,7 @@ impl Default for Window {
             macos_use_unified_titlebar: false,
             macos_use_shadow: true,
             initial_title: None,
-            windows_use_undecorated_shadow: true,
+            windows_use_undecorated_shadow: None,
             windows_use_no_redirection_bitmap: None,
             windows_corner_preference: None,
         }