Emulation state toggle #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PaulWieland
commented
Jul 11, 2024
PaulWieland
commented
- Remove auto detection of security + 1 wall panels
- Add web UI switch to enable or disable emulation mode
- Restore switch state from flash
- Quiet down the debug logging of sec +1 states, should only log upon change of state
change wall panel emulation states from WAITING | ACTIVE to ENABLED | DISABLED. Add set mode to protocol so the GUI switch can toggle the state between enabled or disabled. Default mode is disabled. Removed code that watches for a wall panel to simplify.
for more information, see https://pre-commit.ci
|
The change looked a lot bigger than it is, but that was only because the branch was out of sync with main. I merged it in to get it back in sync |
bdraco
reviewed
Jul 11, 2024
components/ratgdo/ratgdo.cpp
Outdated
Comment on lines
197
to
200
| // auto last_state = this->light_state; | ||
| // if(last_state == light_state){ | ||
| // return; | ||
| // } |
bdraco
reviewed
Jul 11, 2024
components/ratgdo/ratgdo.cpp
Outdated
Comment on lines
209
to
210
| // static LockState last_state = LockState::UNKNOWN; | ||
| // if(light_state != last_state){ |
bdraco
reviewed
Jul 11, 2024
components/ratgdo/ratgdo.cpp
Outdated
Comment on lines
222
to
224
| // if(obstruction_state != last_state){ | ||
| // ESP_LOGD(TAG, "Obstruction: state=%s", ObstructionState_to_string(*this->obstruction_state)); | ||
| // } |
bdraco
reviewed
Jul 11, 2024
Comment on lines
+26
to
+28
| bool value = false; | ||
| this->pref_ = global_preferences->make_preference<float>(this->get_object_id_hash()); | ||
| this->pref_.load(&value); |
There was a problem hiding this comment.
since esp8266 stores prefs in flash this may cause all prefs to be lost when a new one is added since they are restored in order
for more information, see https://pre-commit.ci
…phome-ratgdo into emulation_state_toggle
for more information, see https://pre-commit.ci
Merged
|
Checking in to see if/when this can be merged in please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.