Billable: Create invoice services #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterp
commented
Jan 8, 2025
peterp
commented
- Stub invoice service.
- Display invoice data from datatabase.
justinvdm
added a commit
that referenced
this pull request
Jan 13, 2025
## Problem I added a fix in #36 (44632d7) that caused us to always resolve react to a custom build of react. This custom build caters for the fact that RSC and SSR are sharing a runtime. However, I accidentally made the client side bundling also use this custom build of react, rather than normal react. ## Solution I've added a plugin that allows us to alias react to the custom build of react only for the worker side, but leave it alone on the client side. ## Note While fixing this, I discovered that the current way of having RSC and SSR share a single react build will not work for all things. For example, if there is a `use()` call in SSR-rendered code, we will end up with an issue because RSC is expecting its `use()`` and not the SSR `use()`. I'll work on fixing this in a future PR.
Merged
justinvdm
added a commit
that referenced
this pull request
Jan 13, 2025
## Problem I added a fix in #36 (44632d7) that caused us to always resolve react to a custom build of react. This custom build caters for the fact that RSC and SSR are sharing a runtime. However, I accidentally made the client side bundling also use this custom build of react, rather than normal react. ## Solution I've added a plugin that allows us to alias react to the custom build of react only for the worker side, but leave it alone on the client side. ## Note While fixing this, I discovered that the current way of having RSC and SSR share a single react build will not work for all things. For example, if there is a `use()` call in SSR-rendered code, we will end up with an issue because RSC is expecting its `use()`` and not the SSR `use()`. I'll work on fixing this in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.