refactor pre commit checks #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update flake input for pre-commit-hooks, as the repo was renamed to git-hooks. Refactoring the pre-commit-hooks configuration, following the example provided in the README to use checks for that. Instead of keeping the checks in `flake.nix` directly, start to manage the checks in the checks dir. Rename the original buildInputs attribute of mkShell as nativeBuildInputs should be used for commands that need to run at build time like cmake or shell hooks, according to a discourse thread. So that would also be the case for the pkgs required by the pre-commit-checks, but I keep the config as given in the README first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update flake input for pre-commit-hooks, as the repo was renamed to git-hooks.
Refactoring the pre-commit-hooks configuration, following the example
provided in the README to use checks for that. Instead of keeping the
checks in
flake.nixdirectly, start to manage the checks in thechecks dir.
Rename the original buildInputs attribute of mkShell as
nativeBuildInputs should be used for commands that need to run
at build time like cmake or shell hooks, according to a discourse
thread.
So that would also be the case for the pkgs required by the
pre-commit-checks, but I keep the config as given in the README
first.
Active common checks for typical format weaknesses.