-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incentive Admin Update #647
Conversation
This update includes the |
data/geo_groups.json
Outdated
@@ -1,663 +1,3 @@ | |||
{ | |||
"CA": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So geo group export is broken. I'm not surprised; I'm seeing some new authorities in OR (tribes) that we're not ready to handle, so I bet there's something about how they're defined that's breaking export.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll investigate the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got an email from our OR partners, I didn't realize they were adding tribal members stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed they put a rebate for a gas generator in. Feel free to delete, and I can let them know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is the tribal authorities were added with type 'other' and also added to geo groups which throws an error. A simple solution would be to remove these geo groups while we decided how to handle tribes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could have sworn I'd made a change to block adding other
-type authorities to geo groups, but I guess I didn't. Made a ticket for that: https://app.asana.com/0/1208668890181682/1209171425611390
Anyway, yes, for the time being let's just remove the offending geo groups.
I just created this ticket to be louder about export failures: https://app.asana.com/0/1208668890181682/1209171425611388 Could you investigate what's going wrong with the geo group export? Depending on the problem, the fix might either be editing data in HERO, making a code change, or both. |
48845fa
to
fb428d1
Compare
cd8b978
to
3735ffd
Compare
3735ffd
to
c8e33b5
Compare
This PR updates the API data files, using data maintained by the Incentive Admin.