Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incentive Admin Update #647

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Incentive Admin Update #647

merged 2 commits into from
Jan 23, 2025

Conversation

github-actions[bot]
Copy link
Contributor

This PR updates the API data files, using data maintained by the Incentive Admin.

@cjohnsbrown
Copy link
Contributor

This update includes the items property for the Tier 1 MN programs

@@ -1,663 +1,3 @@
{
"CA": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So geo group export is broken. I'm not surprised; I'm seeing some new authorities in OR (tribes) that we're not ready to handle, so I bet there's something about how they're defined that's breaking export.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll investigate the issue

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got an email from our OR partners, I didn't realize they were adding tribal members stuff.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed they put a rebate for a gas generator in. Feel free to delete, and I can let them know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is the tribal authorities were added with type 'other' and also added to geo groups which throws an error. A simple solution would be to remove these geo groups while we decided how to handle tribes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have sworn I'd made a change to block adding other-type authorities to geo groups, but I guess I didn't. Made a ticket for that: https://app.asana.com/0/1208668890181682/1209171425611390

Anyway, yes, for the time being let's just remove the offending geo groups.

@oyamauchi
Copy link
Member

I just created this ticket to be louder about export failures: https://app.asana.com/0/1208668890181682/1209171425611388
A situation like this should not have made it to being a reviewable PR.

Could you investigate what's going wrong with the geo group export? Depending on the problem, the fix might either be editing data in HERO, making a code change, or both.

@github-actions github-actions bot force-pushed the incentive-admin-update branch from 48845fa to fb428d1 Compare January 16, 2025 22:16
@cjohnsbrown cjohnsbrown requested a review from oyamauchi January 17, 2025 19:00
@github-actions github-actions bot force-pushed the incentive-admin-update branch 2 times, most recently from cd8b978 to 3735ffd Compare January 22, 2025 22:02
@cjohnsbrown cjohnsbrown self-requested a review January 22, 2025 22:20
@github-actions github-actions bot force-pushed the incentive-admin-update branch from 3735ffd to c8e33b5 Compare January 22, 2025 22:32
@cjohnsbrown cjohnsbrown merged commit aa7921d into main Jan 23, 2025
1 check passed
@cjohnsbrown cjohnsbrown deleted the incentive-admin-update branch January 23, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants