[misc-] handle chars with screen width != 1, in unimportant cases #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cliptext, ddwplay, cmdpalette, form, sheets, and statusbar.
midichef
changed the title
saulpw
reviewed
Jan 12, 2025
| @@ -32,7 +32,7 @@ | |||
| BaseSheet.init('longname', lambda: '') | |||
|
|
|||
| def fitWithin(s, n=10): | |||
| if len(s) > n: | |||
| if dispwidth(s) > n: | |||
| return s[:n//2-1] + '…' + s[-n//2+1:] | |||
There was a problem hiding this comment.
This would need to use the same kind of partition() function that was mentioned in #2662.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
472953e - fixes behavior in several files. The effects are minor.
And I added this comment:
# textwrap.wrap does not handle variable-width characters #2416because it seems I need the reminder, as I just looked into
textwrap's handling of such characters, eventually discovering I looked into it several months ago but forgot.5ae669b - should not change behavior of current visidata in any visible way. But in the future, if menus use variable-width characters, it would matter.
cb2bad3 -
man/parse_options.py, it should not change current behavior.1c707a1 -
ddwplay.pyforAnimation.loadfrom(). I did not test this change, as I do not know how to testAnimation.066db54 - These changes are not strictly necessary, as the
promptstrings are standard ASCII text. The fix is only for completeness, useful only if the code is copy/pasted or altered.With this PR, my audit of
len()vsdispwidth()is finished.