[csv-] warn when guessed option differs from default #2690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When csv is guessed without a filetype, visidata uses Python's
csv
library to guess the parsing options using csv.Sniffer. For the simplest csv files, it seems thatdoublequote
isFalse
, whereas the default in visidata isTrue
. That can surprise users, as it did in #2689.This PR makes the guessing process more obvious. It outputs a warning for all guessed CSV options that differ from visidata's defaults:
(versions that do the silent guessing are 3.0 and up)
Or should we override the
Sniffer
guesses to use visidata's defaults?