Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various parts #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add various parts #165

wants to merge 1 commit into from

Conversation

SFE-Brudnerd
Copy link
Member

Add existing PFET.
Add existing SMD Barrel Jack.
Add 3-pin Vertical JST 1mm.
Add existing 1x08 and 1x10 SMD headers.
Add 1x22 FPC 0.5mm.

Add existing PFET.
Add existing SMD Barrel Jack.
Add 3-pin Vertical JST 1mm.
Add existing 1x08 and 1x10 SMD headers.
Add 1x22 FPC 0.5mm.
@SFE-Brudnerd SFE-Brudnerd requested a review from nseidle January 9, 2025 16:12
@nseidle
Copy link
Member

nseidle commented Jan 9, 2025

This is great! Thanks for adding the 3D models.

  • Where did the 3D models come from? They need to have a clear open source or public domain license or else we can't use them.
  • FPC_0.5mm-22_Vertical.kicad_mod - Please include a link to the datasheet that the FP was generated from
  • CF20221V0R0-NH.STEP looks like it needs coloring
  • JST_SMD_1.0mm-3_Vertical.kicad_mod needs datasheet link
  • Power_Jack_SMD.kicad_mod datasheet would be nice
  • Fix part name of CONN-24642 in sparkle to match format of other connectors in sparkle
  • Fix part name of CONN-24643 in sparkle to match format of other connectors in sparkle
  • Smaller PRs in the future please or a list of the components touched. The diff on SparkFun-Connector.kicad_sym is wicked.
  • Conn_01x06_SMD_Pin1Right needs PROD ID and datasheet
  • Not sure if you have it, but a FP for 1x06 SMD pass through would be good for completeness
  • Not sure if you have it, but a FP for 1x10 SMD pass through would be good for completeness
  • Conn_01x08_SMD_Pin1Right needs prod ID and datasheet
  • Conn_01x10_SMD_Pin1Right needs prod ID and datasheet
  • Part Conn_01x22_FPC_0.5mm_HSTX_RA don't not have a valid FP. Also needs prod ID.
  • Power_Jack_SMD.kicad_mod needs a courtyard (I know, not your FP, but please help make it better). Same for Power_Jack_SMD_Overpaste_TOE.
  • What do you think about renaming the power jack FPs to 'barrel jack' type nomenclature to match the barrel jack sym name? Power jack is fairly generic where the 'barrel' is more specific.
  • Pin numbering on symbol D_Schottky_3A_40V_0.55V looks different/wrong. Other diodes use pin 1/2. This one is using C/A. Please match other devices in the lib.

@SFE-Brudnerd
Copy link
Member Author

Where did the 3D models come from? They need to have a clear open source or public domain license or else we can't use them.

For the BG125 and DCJ models, I got them GCT.co's website, this is all I could find. It's more of a release than a license...

GCT Disclaimer
This information has been provided to you free of charge for your use but remains the sole property of Global Connector Technology (GCT). 
In no event will GCT or its contractors, directors, officers, employees, affiliates or distributors be liable for any direct, indirect, special, incidental or consequential damages (including but not limited to, damages for lost business, lost profits, business interruptions and loss of information) arising from your use of, or your inability to use the CAD models or any accompanying written materials, even if GCT has been advised of the possibility of such damages. 
The information you are about to download may not be complete or accurate, and the products depicted in drawings, models, specifications, and other types of content may not be to scale, or the most recent version. 
In some cases internal product details have been omitted to protect our designs. 
There may be minor revisions to a product since the 3d was last updated, however none should effect form, fit and function. 
GCT makes no warranty or guarantee as to the suitability of its products or models for any specific application. 
GCT reserves the right to make changes at any time without further notice. 
By downloading a model, the user agrees to absolve GCT from all liability related to the use or application of the model or product. 
GCT will in no case be liable for your use, or the results of your use, of the CAD models or any accompanying written materials. 
IT IS YOUR RESPONSIBILITY TO VERIFY THE RESULTS OF YOUR USE OF THIS INFORMATION IN YOUR OWN PARTICULAR ENGINEERING AND PRODUCT ENVIRONMENT AND YOU ASSUME THE ENTIRE RISK OF DOING SO OR FAILING TO DO SO.

The BM03 I got from Digi-Key via SnapEDA. That is Creative commons.

The CF STEP I got directly from the manufacturer's website, but there's no license information. I can remove that model if need be.

FPC_0.5mm-22_Vertical.kicad_mod - Please include a link to the datasheet that the FP was generated from

Datasheet link is in the symbol, but can do.

CF20221V0R0-NH.STEP looks like it needs coloring

Don't know how to do this but I'll figure it out.

JST_SMD_1.0mm-3_Vertical.kicad_mod needs datasheet link

Datasheet link is in the symbol, but can do.

Power_Jack_SMD.kicad_mod datasheet would be nice

Datasheet link is in the symbol, but can do.

Fix part name of CONN-24642 in sparkle to match format of other connectors in sparkle
Fix part name of CONN-24643 in sparkle to match format of other connectors in sparkle

Can do.

Smaller PRs in the future please or a list of the components touched. The diff on SparkFun-Connector.kicad_sym is wicked.

Agreed, will do next time. I'm working on 2 designs right now simultaneously, so there's a fair bit of change here. I thought I covered everything in my PR list.

Conn_01x06_SMD_Pin1Right needs PROD ID and datasheet
Conn_01x08_SMD_Pin1Right needs prod ID and datasheet
Conn_01x10_SMD_Pin1Right needs prod ID and datasheet

Can do.

Not sure if you have it, but a FP for 1x06 SMD pass through would be good for completeness
Not sure if you have it, but a FP for 1x10 SMD pass through would be good for completeness

I can add them in.

Part Conn_01x22_FPC_0.5mm_HSTX_RA don't not have a valid FP. Also needs prod ID.

I need to remove this, good catch.

Power_Jack_SMD.kicad_mod needs a courtyard (I know, not your FP, but please help make it better). Same for Power_Jack_SMD_Overpaste_TOE.

Can do.

What do you think about renaming the power jack FPs to 'barrel jack' type nomenclature to match the barrel jack sym name? Power jack is fairly generic where the 'barrel' is more specific.

I like this. I will make the change.

Pin numbering on symbol D_Schottky_3A_40V_0.55V looks different/wrong. Other diodes use pin 1/2. This one is using C/A. Please match other devices in the lib.

I forget why this one is different, I probably just overcorrected in the wrong direction.

Thanks for the feedback I'll get these changes in!

@nseidle
Copy link
Member

nseidle commented Jan 9, 2025

WRT libraries = excellent, thanks for the provenance. Disclaimers of liability are ok, just watch out for any license.txt that disallows repacking a specific 3D model into a larger library. Digikey/SnapMagic does this on some parts:

Individual Models remain the intellectual property of SnapMagic Search, Inc. You shall not (and shall not permit or encourage any third party to) to do any of the following :

(a) sell, assign, lease, lend, rent, issue, sublicense, make available, or otherwise distribute to any third party, or publicly perform, display or communicate, the Models (for example, by uploading Models to another website or software application);

Just be aware and avoid them.

Datasheet link is in the symbol, but can do.

Thanks. Datasheet in the symbol is the #1 goal, but when we're questioning why a FP is the way it is, it's really nice to have the primary source listed in the FP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants