-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CheckboxTree component #1495
Conversation
7bacfa3
to
f23a4c0
Compare
ui/src/components/CheckboxTree/stories/CheckboxTree.stories.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Viktor Tsvetkov <[email protected]>
Signed-off-by: Viktor Tsvetkov <[email protected]>
Signed-off-by: Viktor Tsvetkov <[email protected]>
Signed-off-by: Viktor Tsvetkov <[email protected]>
Signed-off-by: Viktor Tsvetkov <[email protected]>
Signed-off-by: Viktor Tsvetkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still reviewing but will post just after adding, feel free to close if something seems like a bad/worse idea
Signed-off-by: Viktor Tsvetkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional ideas/questions.
Generally looks good to me.
Seems like Viktor got a good point regarding those css-s, it might be useful to get rid of as much as we can. (I would say worth removing even if it will make feature looks a bit worse)
Signed-off-by: Viktor Tsvetkov <[email protected]>
Suggested pull request title: feat: add CheckboxTree component for hierarchical checkbox management Great work on implementing a new CheckboxTree component that provides a hierarchical structure for managing checkboxes! The implementation looks clean and well-organized, with proper testing and documentation in place. I especially appreciate:
Here are a few suggestions for improvements:
Overall, this is a solid implementation that appears ready for merging after addressing these minor suggestions. The component will be a valuable addition to the UI framework. This comment was added by our PR Review Assistant Bot. Please kindly acknowledge that To reply to the review and engage Review Bot in further conversation, start your comment with the words |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work
Issue number: ADDON-76198
PR Type
What kind of change does this PR introduce?
Summary
Changes
A new component
CheckboxTree
has been introduced to define hierarchical checkbox structures with support of search functionality.User experience
User can use the new component for handling the list of checkboxes with better UI including the expanding/collapsing, grouping and searching within the checkbox list.
Checklist
If an item doesn't apply to your changes, leave it unchecked.