Fix: input label accessibility #1518
Draft
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanm-crest
changed the title
There was a problem hiding this comment.
It does not work for any of oauth fields
There was a problem hiding this comment.
don't forget about tests. Although, adding tests exactly for this is extra, I would just indirectly test it by simplifying existing tests and utilising semantic selectors
https://testing-library.com/docs/queries/about#priority
For example, FormModifications.test.tsx may be simplified by using getByRole instead of getTextElementForField and getCheckBoxElementForField
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-68266
PR Type
What kind of change does this PR introduce?
Summary
Changes
Please provide a summary of the changes.
User experience
Please describe the user experience before and after this change. Screenshots are welcome for additional context.
Checklist
If an item doesn't apply to your changes, leave it unchecked.