Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Upgrades dependencies #30183

Draft
wants to merge 4 commits into
base: norbert/upgrades-2025-1
Choose a base branch
from

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 3, 2025

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.8 MB 77.8 MB 0 B - 0%
initSize 131 MB 131 MB 562 kB Infinity 0.4%
diffSize 53 MB 53.5 MB 562 kB Infinity 1%
buildSize 7.19 MB 7.18 MB -9.02 kB -Infinity -0.1%
buildSbAddonsSize 1.85 MB 1.83 MB -17.1 kB -Infinity -0.9%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.87 MB 1.88 MB 10.2 kB Infinity 0.5%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.91 MB 3.9 MB -6.89 kB -Infinity -0.2%
buildPreviewSize 3.28 MB 3.27 MB -2.13 kB -Infinity -0.1%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 21.3s 25.8s 4.4s Infinity 🔺17.4%
generateTime 19.8s 19.1s -706ms -Infinity -3.7%
initTime 12.8s 13s 191ms Infinity 1.5%
buildTime 8s 10.7s 2.7s Infinity 🔺25.7%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 4.8s 4.6s -233ms -Infinity 🔰-5.1%
devManagerResponsive 3.6s 3.3s -321ms -Infinity 🔰-9.6%
devManagerHeaderVisible 640ms 542ms -98ms -Infinity 🔰-18.1%
devManagerIndexVisible 669ms 573ms -96ms -Infinity 🔰-16.8%
devStoryVisibleUncached 1.8s 1.9s 62ms Infinity 3.2%
devStoryVisible 670ms 575ms -95ms -Infinity 🔰-16.5%
devAutodocsVisible 585ms 517ms -68ms -Infinity 🔰-13.2%
devMDXVisible 597ms 476ms -121ms -Infinity 🔰-25.4%
buildManagerHeaderVisible 579ms 605ms 26ms Infinity 4.3%
buildManagerIndexVisible 675ms 709ms 34ms Infinity 4.8%
buildStoryVisible 561ms 581ms 20ms Infinity 3.4%
buildAutodocsVisible 526ms 501ms -25ms -Infinity -5%
buildMDXVisible 484ms 462ms -22ms -Infinity -4.8%

@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jan 3, 2025
@ndelangen ndelangen self-assigned this Jan 3, 2025
Copy link

nx-cloud bot commented Jan 3, 2025

View your CI Pipeline Execution ↗ for commit 918ae08.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 38s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-03 16:11:38 UTC

@mrginglymus
Copy link

Some overlap with #30031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants