Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes/#650 needless favicon fetch fix #652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes/#650 needless favicon fetch fix #652

wants to merge 1 commit into from

Conversation

ad1tyayadav
Copy link

This PR fixes #650

Screen.Recording.2025-01-20.144935.mp4

@ad1tyayadav ad1tyayadav mentioned this pull request Jan 20, 2025
Open
@ad1tyayadav ad1tyayadav changed the title fixes/#650 needles favicon fetch fix fixes/#650 needless favicon fetch fix Jan 20, 2025
quozl
quozl requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@quozl quozl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't fix the problem; when the icon is changed in line 33 of your code, the browser has still begun to GET the icon that was set by the include and that GET is cancelled.

js/main.js
if (logoID < 10) {
logoID = "0" + logoID;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove these lines?

js/main.js
var defaultIcon = document.querySelector('#defaultIcon1');
if (defaultIcon) {
var logoID = colorIndex + 1;
if (logoID < 10) {
logoID = "0" + logoID;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quozl quozl quozl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Needless double GET of favicon
2 participants
@ad1tyayadav @quozl