Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add cursor pointer to TabButton component #1996

Closed
wants to merge 1 commit into from

Conversation

lopadz
Copy link

@lopadz lopadz commented Jan 25, 2025

Changes

Improve the UX by updating the TabButton component on the homepage with the missing cursor-pointer style 🙂

How Has This Been Tested?

Visually

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 4:17am

@adamwathan
Copy link
Member

Hey thanks! Going to keep this as-is for now as cursor: default is consistent with what the browser does for buttons by default, and how all other buttons work in the operating system.

It's a bit controversial for sure, lot of discussion about it here:

https://ux.stackexchange.com/questions/105024/why-dont-button-html-elements-have-a-css-cursor-pointer-by-default

But yeah going to roll with it for now, maybe will change my mind one day we'll see :)

Thanks either way!

@adamwathan adamwathan closed this Jan 25, 2025
@lopadz lopadz deleted the missing-cursor-style branch January 25, 2025 18:44
@lopadz
Copy link
Author

lopadz commented Jan 25, 2025

Oh very informative! Never knew this was a thing in all my years of building sites. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants