Skip to content

Commit

Permalink
Fix pre-existing linter errors
Browse files Browse the repository at this point in the history
  • Loading branch information
ptomato committed Aug 26, 2022
1 parent 391aecf commit 018e33e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions stage-3-review.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ According to [the TC39 process document](https://tc39.es/process-document), to a
Reviewers for Stage 3 volunteer as such in TC39 meetings when discussing a proposal. If the proposal is ready, the champion can ask the committee for reviewers at the same meeting as it advances to Stage 2. Sizable proposals are encouraged to have multiple reviewers. Different reviewers can provide different perspectives.

Reviewer feedback is tracked in a GitHub issue in the proposal repository ([example](https://github.com/tc39/proposal-regexp-unicode-property-escapes/issues/3)). It may also be useful to send out a reminder email ahead of the meeting to the reviewers.

## Performing a review

When reviewing a TC39 proposal, read the specification text, README and other documentation carefully. Some questions which may be useful to consider in a review:

- Does the proposal address its stated motivation?
- Is this language feature intuitive and learnable?
- Does the proposal fit in well when combined with other JavaScript language features (both current and proposed, a.k.a. "cross-cutting concerns")? Will the interactions between features be surprising or strange?
Expand All @@ -22,4 +23,3 @@ When reviewing a TC39 proposal, read the specification text, README and other do
To give your feedback to the champion group, file issues in GitHub, or make pull requests with proposed changes.

Reviews are expected to be performed at least two weeks in advance of the TC39 meeting.

0 comments on commit 018e33e

Please sign in to comment.