Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnote Extension #484

Merged
merged 1 commit into from
May 24, 2020
Merged

Footnote Extension #484

merged 1 commit into from
May 24, 2020

Conversation

colinodell
Copy link
Member

This extension is based on https://github.com/rezozero/commonmark-ext-footnotes, imported and relicensed with permission from the maintainer: #474 (comment)

In addition to importing the functionality, a number of configuration options were added, as well as some other small tweaks.

This extension is based on https://github.com/rezozero/commonmark-ext-footnotes,
imported and relicensed with permission from the maintainer:
#474 (comment)

In addition to importing the functionality, a number of configuration
options were added, as well as some other small tweaks.
@colinodell colinodell added this to the v1.5 milestone May 23, 2020
@colinodell colinodell self-assigned this May 23, 2020
Copy link
Contributor

@markhalliwell markhalliwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this LGTM.

@markhalliwell
Copy link
Contributor

markhalliwell commented May 24, 2020

I've added support for this in the Drupal Markdown module:

https://git.drupalcode.org/project/markdown/commit/0749113

Screen Shot 2020-05-24 at 1 46 55 PM

Screen Shot 2020-05-24 at 2 06 29 PM

colinodell added a commit that referenced this pull request May 25, 2020
This extension is based https://github.com/webuni/commonmark-attributes-extension,
imported and relicensed with permission from the maintainer:
#474 (comment)
colinodell added a commit that referenced this pull request May 25, 2020
This extension is based https://github.com/webuni/commonmark-attributes-extension,
imported and relicensed with permission from the maintainer:
#474 (comment)
colinodell added a commit that referenced this pull request May 26, 2020
This extension is based https://github.com/webuni/commonmark-attributes-extension,
imported and relicensed with permission from the maintainer:
#474 (comment)
colinodell added a commit that referenced this pull request May 26, 2020
This extension is based https://github.com/webuni/commonmark-attributes-extension,
imported and relicensed with permission from the maintainer:
#474 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants