-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support limits #180
base: master
Are you sure you want to change the base?
Support limits #180
Conversation
Hi @parkourben99 Thank you for the PR! This package is designed to support Laravel versions prior to 11. However, the Laravel version constraint in your composer.json file would restrict compatibility with those versions. |
"illuminate/database": ">=5.6 <12.0" | ||
"php": "^8.0", | ||
"illuminate/database": "^11.0", | ||
"laravel/serializable-closure": "^1.3|^2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, the Laravel version constraint in your composer.json file would restrict compatibility with those versions.
Remove this line
-"php": "^8.0",
-"illuminate/database": "^11.0",
-"laravel/serializable-closure": "^1.3|^2.0"
+"illuminate/database": ">=5.6 <12.0"
Also merge it with master
I'm not sure these changes will work with previous versions of laravel, due to the recent change in laravel to support limits. Do the tests run on previous versions? |
* @covers \Awobaz\Compoships\Database\Grammar\MySqlGrammar | ||
*/ | ||
public function test_relation_limit() | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure these changes will work with previous versions of laravel
Add something like this
if (getLaravelVersion() < 11.0) {
$this->markTestIncomplete('This test is broken on laravel 10.x and earlier!');
}
compoships/tests/ComposhipsTest.php
Lines 266 to 268 in 9b37b51
if (getLaravelVersion() < 8.0) { | |
$this->markTestIncomplete('This test is broken on laravel 7.x and earlier!'); | |
} |
Fixes #173
Support sub query limits. Now that the Eloquent Eager Limit package is native in Larave 11l.
example usage: