New variable relation filter syntax + upgrade command #9765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| } | ||
|
|
||
| await this.workspaceMigrationRunnerService.executeMigrationFromPendingMigrations( |
There was a problem hiding this comment.
This will never break in prod @charlesBochet?
|
|
||
| const { selectedRecordIds, isCurrentWorkspaceMemberSelected } = | ||
| jsonRelationFilterValueResult.data; | ||
|
|
There was a problem hiding this comment.
I'm wondering if we should also convert dates to {{}}. We don't need it because it requires a special operand but maybe it would have been best for consistency. In any case it'd be best in a separate PRs even if it's to edit the same command.
cc @charlesBochet to decide. I'm ok to not doing dates, I think we can always do it later.
| const parsedFilterValue = relationFilterValueSchema.parse( | ||
| viewFilterUsedInDropdown?.value, | ||
| ); | ||
|
|
There was a problem hiding this comment.
I was initially hoping we could do something a bit more elegant that replaces {{ }} at a higher level for all filter types, but it's maybe more pragmatic to go for that! Fine with me. cc @charlesBochet again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of the new syntax for relation filter values:
["5f72796c-727f-47eb-aab0-e8c61d1fc052", "de65f27f-685f-4388-bc38-8396c19f88af", "{{CURRENT_WORKSPACE_MEMBER}}"]