[APP-7257] Support older NM (>1.30.0) and hardware that cannot scan in hotspot mode #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otterverse
changed the title
ale7714
approved these changes
Dec 18, 2024
Otterverse
commented
Dec 18, 2024
| conf.DeviceRebootAfterOfflineMinutes < conf.OfflineTimeout || | ||
| conf.DeviceRebootAfterOfflineMinutes < conf.UserTimeout { | ||
| return &conf, errw.Errorf("device_reboot_after_offline_minutes cannot be less than offline_timeout or user_timeout") | ||
| (conf.DeviceRebootAfterOfflineMinutes < conf.OfflineTimeout || conf.DeviceRebootAfterOfflineMinutes < conf.UserTimeout) { |
There was a problem hiding this comment.
It took me WAY too long to figure out this was the issue. One pair of missing parenthesis! So easy to miss!
ale7714
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: rc2 replaces rc1. Fix a timeout issue that caused erratic behavior on "normal" (read, previously fully working) systems.
EDIT: rc1 replaces rc0. Minor fix for unrelated reboot timeout code.
Two main changes...
If NM older than 1.38, avoid using RadioFlags to disable when wifi hardware is absent, and rely on later device scan.
Modify wifi scanning to detect repeated failures when in hotspot mode, and (after 3) disable such scans after warning the user. This means the network list in the web portal or provided to the mobile app may be several minutes out of date, as scan data had to come from before the hotspot was started. May want to advise users to reduce the fallback timeout to a lower interval if this causes them problems. Otherwise we hang out in hotspot for 10 minutes, even if a wifi network we know comes in range, we can't see it until hotspot exits to allow a scan.
Test build: