Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA-1976 - Add DeleteCompletedTrainingJob to API #387

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

agreenb
Copy link
Contributor

@agreenb agreenb commented Oct 26, 2023

@agreenb agreenb requested a review from tahiyasalam October 26, 2023 21:29
Copy link
Member

@tahiyasalam tahiyasalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agreenb agreenb added dependencies Pull requests that update a dependency file protos-compiled and removed dependencies Pull requests that update a dependency file protos-compiled labels Oct 30, 2023
@agreenb agreenb requested a review from tahiyasalam October 30, 2023 17:33
@agreenb
Copy link
Contributor Author

agreenb commented Oct 30, 2023

@tahiyasalam could you reapprove? Ran into an issue with generated compiled protos

@agreenb agreenb added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Oct 30, 2023
@agreenb agreenb added enhancement New feature or request and removed enhancement New feature or request labels Oct 31, 2023
@agreenb agreenb merged commit b4e6318 into viamrobotics:main Oct 31, 2023
2 checks passed
maxhorowitz added a commit that referenced this pull request Oct 31, 2023
* upstream/main:
  DATA-1976 - Add DeleteCompletedTrainingJob to API (#387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants