APP-2437: update OrgDetails proto for ops dashboard improvements #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohEmily
added
the
ready-for-protos
ohEmily
commented
Dec 4, 2024
Comment on lines
+1367
to
+1382
| message SearchOrganizationsRequest { | ||
| optional string org_id = 1; | ||
| optional string org_name = 2; | ||
| optional string cid = 3; | ||
| optional string public_namespace = 4; | ||
| } |
There was a problem hiding this comment.
[self] didn't use oneof per our eng guidelines
Avoid oneof except for enums, since non-scalar oneofs are hard to work with in most protoc generations
ohEmily
removed
the
ready-for-protos
|
Apparently I need to remove the "ready for protos" label to stop these guys from getting stuck: just removed the label, hopefully that helps |
|
Abe pointed out I probably picked up a deprecation and got unlucky on timing, this guy: #595 |
ohEmily
added
the
ready-for-protos
ohEmily
removed
the
ready-for-protos
ohEmily
added
ready-for-protos
ohEmily
added
ready-for-protos
…earch features APP-2437: Add SearchOrganizations gRPC
|
GitHub labeling integration is having a bad day. Doing some creative rebasing and force pushing to see if I can fix it. |
ohEmily
removed
the
ready-for-protos
JosephBorodach
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APP-2437
Included
public_namespaceandorg nameas well to the new search message type because I can see us implementing these in time. Only doing search on CRM ID at this stage to keep the changes tightly scoped.