Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-7502: Update FragmentHistoryEntry for fragment versioning #622

Merged
merged 7 commits into from
Jan 24, 2025
Merged

APP-7502: Update FragmentHistoryEntry for fragment versioning #622

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
960b9ef
Update FragmentHistoryEntry for fragment versioning
michaellee1019 Jan 24, 2025
5729429
tags
michaellee1019 Jan 24, 2025
451c1b8
minus ;
michaellee1019 Jan 24, 2025
3951590
Update app.proto
michaellee1019 Jan 24, 2025
3da78d3
Merge branch 'main' into michaellee1019-patch-1
michaellee1019 Jan 24, 2025
e5b9b11
Built new protos from 3da78d3
github-actions[bot] Jan 24, 2025
a178bdd
Merge branch 'main' into michaellee1019-patch-1
michaellee1019 Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions proto/viam/app/v1/app.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,6 +820,8 @@ message FragmentHistoryEntry {
google.protobuf.Timestamp edited_on = 2 [(tagger.v1.tags) = "bson:\"edited_on\" json:\"edited_on\""];
Fragment old = 3 [(tagger.v1.tags) = "bson:\"old\" json:\"old\""];
AuthenticatorInfo edited_by = 4 [(tagger.v1.tags) = "bson:\"edited_by\" json:\"edited_by\""];
string revision = 5 [(tagger.v1.tags) = "bson:\"revision\" json:\"revision\""];
google.protobuf.Struct config = 6 [(tagger.v1.tags) = "bson:\"fragment\" json:\"fragment\""];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double checking, this field config will eventually replace old? also, should the bson tags be config as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops my bad about the tags, will update. Yes I think old will be deprecated. It doesn't make sense to drive the fragment version history off of old if we are storing that version's config as well. Plus its confusing to have the entire fragment in the response.

We have a lot of tasks to complete to migrate completely off of old and then we can deprecate it everywhere.

}

enum FragmentVisibility {
Expand Down
Loading