Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-9714: Call WaitGroup.Done in too many in-flight requests error path. #401

Merged
merged 1 commit into from
Jan 10, 2025
Merged

RSDK-9714: Call WaitGroup.Done in too many in-flight requests error path. #401

merged 1 commit into from
Jan 10, 2025

Conversation

dgottlieb
Copy link
Member

No description provided.

@dgottlieb dgottlieb requested a review from benjirewis January 9, 2025 19:36
@viambot viambot added the safe to test Mark as safe to test label Jan 9, 2025
benjirewis
benjirewis approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this result in a deadlock somewhere?

@dgottlieb dgottlieb merged commit a4cfa8d into viamrobotics:main Jan 10, 2025
6 checks passed
@dgottlieb dgottlieb deleted the RSDK-9714 branch January 10, 2025 02:06
@dgottlieb
Copy link
Member Author

I don't have the application logs/FTDC data that would definitively say whether "too many in-flight requests" happened, but there was a case of wrtc server shutdown waiting for that waitgroup to drain, and there were no goroutines inside of processHeaders beyond the .Add(1) step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjirewis benjirewis benjirewis approved these changes

Assignees
No one assigned
Labels
safe to test Mark as safe to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgottlieb @benjirewis @viambot