APP-7268: Add nav dropdown #615
Open
+291
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjinai
commented
Jan 9, 2025
| <script lang="ts"> | ||
| import { clickOutside } from '$lib/click-outside'; | ||
| import { Icon } from '$lib/icon'; | ||
| import { goto } from '$app/navigation'; |
There was a problem hiding this comment.
Is goto from app/navigation the right thing to use to navigate to the selected href?
anjinai
commented
Jan 9, 2025
| </button> | ||
|
|
||
| {#if isOpen} | ||
| <div |
There was a problem hiding this comment.
The ticket mentioned to use nav element with a links, however, the linter was upset with me when I gave the nav element the role of menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a new
NavDropdowncomponent that will be used in app to navigate between different versions of fragments. This dropdown allows for version selection while displaying additional data like timestamps and descriptions.Ticket: https://viam.atlassian.net/browse/APP-7268
Figma: https://www.figma.com/design/g7uvrGb1Wwdasr4tw6kPpu/Fragments?node-id=6231-12788&t=3olT5Jeslga6pn75-4