Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATA-3345 Update go SDK with exportTabularData #4597

Closed
wants to merge 0 commits into from
Closed

DATA-3345 Update go SDK with exportTabularData #4597

wants to merge 0 commits into from

Conversation

vijayvuyyuru
Copy link
Member

@vijayvuyyuru vijayvuyyuru commented Dec 3, 2024 •
edited
Loading

Hey yall, this PR updates the Go SDK to include the ExportTabularData endpoint.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 3, 2024
@vijayvuyyuru vijayvuyyuru marked this pull request as ready for review December 3, 2024 20:34
purplenicole730
purplenicole730 requested changes Dec 4, 2024
View reviewed changes
app/data_client.go Outdated Show resolved Hide resolved
app/data_client.go Outdated Show resolved Hide resolved
app/data_client.go Outdated Show resolved Hide resolved
app/data_client.go Outdated Show resolved Hide resolved
app/data_client.go Outdated Show resolved Hide resolved
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 4, 2024
vijayvuyyuru
vijayvuyyuru commented Dec 4, 2024
View reviewed changes
app/data_client_test.go Outdated Show resolved Hide resolved
purplenicole730
purplenicole730 requested changes Dec 4, 2024
View reviewed changes
app/data_client_test.go Outdated Show resolved Hide resolved
app/data_client.go Outdated Show resolved Hide resolved
app/data_client.go Outdated Show resolved Hide resolved
app/data_client.go Outdated Show resolved Hide resolved
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 4, 2024
purplenicole730
purplenicole730 reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Holding off on approving until we get the new Any type in here. It'll be incommon.go. I'll notify when the Any type is available for you to use!

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 4, 2024
@viambot viambot removed the safe to test This pull request is marked safe to test from a trusted zone label Dec 4, 2024
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Dec 5, 2024
katiepeters
katiepeters reviewed Dec 5, 2024
View reviewed changes
app/data_client.go Outdated
Stream pb.DataService_ExportTabularDataClient
}

// Next gets the next ExportTabularDataReturn.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update use of Return in comments

purplenicole730
purplenicole730 requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting this back so that I get a reminder to double check everything once you change the type for MethodParameters to map[string]interface{}

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 5, 2024
purplenicole730
purplenicole730 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for making you go back and forth, but this looks good to me!

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 9, 2024
@vijayvuyyuru
Copy link
Member Author

@purplenicole730 @katiepeters I updated this PR with the newest API changes. (ComponentName and ComponentType became ResourceName and ResourceSubtype) and (Additional parameters became a structpb, but still returning as a map of string to interfaces)

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 9, 2024
purplenicole730
purplenicole730 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Admittedly, I only took a quick glance to confirm the changes that you specified.

katiepeters
katiepeters reviewed Dec 9, 2024
View reviewed changes
app/data_client.go Outdated
@@ -1229,6 +1288,24 @@ func tabularDataFromProto(proto *pb.TabularData, metadata *pb.CaptureMetadata) T
}
}

func exportTabularDataReturnFromProto(proto *pb.ExportTabularDataResponse) *ExportTabularDataResponse {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: rename exportTabularDataResponseFromProto

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 9, 2024
@katiepeters
Copy link
Member

Looking pretty good now! Will approve once the method is actually available to use

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 16, 2024
@vijayvuyyuru vijayvuyyuru mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purplenicole730 purplenicole730 purplenicole730 approved these changes

@katiepeters katiepeters katiepeters approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vijayvuyyuru @katiepeters @purplenicole730 @viambot