Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sensors service #4598

Merged
merged 5 commits into from
Dec 11, 2024
Merged

remove sensors service #4598

merged 5 commits into from
Dec 11, 2024

Conversation

randhid
Copy link
Member

@randhid randhid commented Dec 3, 2024

Remove the deprecated sensors service from rdk.
We will want to remove from the sdks that have it first + check with SEs that no one uses this.

@randhid randhid requested a review from cheukt December 3, 2024 20:44
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Dec 3, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 3, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 4, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 4, 2024
cheukt
cheukt approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can merge after 12/10 release

robot/impl/local_robot_test.go Outdated Show resolved Hide resolved
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 9, 2024
@randhid randhid merged commit cd49068 into viamrobotics:main Dec 11, 2024
16 checks passed
@randhid randhid deleted the remove-sensors-service branch December 12, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheukt cheukt cheukt approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randhid @cheukt @viambot