App 6822: Adding CLI command to update the billing service

[RoxyFarhad]

The caveat here is that we need to pass in an address as a CLI command, IMO there are 2 possible ways to do this :

1. Have each part of the address: line1, line2, city, state, zipcode as its own flag e.g. billing-service update --line1=<line-1> ---line-2=<line2> --city=<city> --state=<state> --zipcode=<zipcode>
2. Pass in the address like a string like so and then we parse it under the hood e.g. billing-service update --address="line1, line2, city, state, zipcode"

I implemented 2 because I thought it was a better UX to the user but open to opinions here

Manual Testing:

[jr22]

lol

[jr22]

can we assume this actually? do we care if its USA?

[RoxyFarhad]

I made the same assumption as our Stripe payment assumptions:

1. we can't charge people outside of the US because we haven't integrated Stripe's internal tax product yet.

I think we also can't pay people directly on stripe because of this?

I actually didn't mention this as a non-goal on the scope, but I can get confirmation.

[jr22]

cool sounds good!

[RoxyFarhad]

I made a ticket to change it at the end of the epic as steve said its non-prio but it will actually require an API change

[jr22]

or "line1, city, state, zipcode" right?

[RoxyFarhad]

yeah, Ill add a line2 (optional) to the helper text

[jr22]

[style, optional] ik repeated code in this but might be more readable to do something like this:

Suggested change

	currIndex := 0
	addr.AddressLine_1 = splitAddress[currIndex]
	currIndex++
	if len(splitAddress) == 4 {
	// if its only 4 lines long that means that there is no line2
	currIndex++
	} else {
	addr.AddressLine_2 = &splitAddress[currIndex]
	currIndex++
	}
	addr.City = splitAddress[currIndex]
	currIndex++
	addr.State = splitAddress[currIndex]
	currIndex++
	addr.Zipcode = splitAddress[currIndex]
	return addr, nil
	if len(splitAddress) == 4 {
	return &apppb.BillingAddress{
	Address_Line_1: splitAddress[0],
	City: splitAddress[1],
	State: splitAddress[2],
	Zipcode: splitAddress[3],
	}, nil
	}
	return &apppb.BillingAddress{
	Address_Line_1: splitAddress[0],
	Address_Line_2: splitAddress[1],
	City: splitAddress[2],
	State: splitAddress[3],
	Zipcode: splitAddress[4],
	}, nil

[RoxyFarhad]

yea thats what i had before, ill revert back to that 👍🏼

[jr22]

few nits and looks like tests and stuff are failing but otherwise looks good. will approve with screenshot of manual test ?