APP-6993: Deprecate legacy auth-app commands in favor of oauth-app commands #4732
Conversation
viambot
added
the
safe to test
| @@ -2755,106 +2755,6 @@ This won't work unless you have an existing installation of our GitHub app on yo | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
| Name: "auth-app", | |||
There was a problem hiding this comment.
Question: anything special i should do when removing this command? is this an ok breaking change? dont think anyone was using these since they werent feature complete. ill make sure docs are updated too
There was a problem hiding this comment.
dont think anyone was using these since they feature complete.
I'm not sure I understand this sentence, do you mind rephrasing?
Re: the breaking change, I guess I want to understand a little bit more what the impetus for this is. It looks to me like the proto AuthApp methods still exist... is there a plan to delete those entirely? If not, how do we intend for them to still be used, and why are we wanting to delete them from the CLI but not elsewhere?
There was a problem hiding this comment.
this is part of a series of PRs to deprecate these protos and CLI commands:
- API PR: APP-6993: Deprecate legacy auth app apis api#615
- APP PR: https://github.com/viamrobotics/app/pull/7277
Ill add these links to the PR description.
As for why we're doing this... we created these commands initially almost as a quick MVP for people creating auth apps. After we created them, we realized they were missing quite a few features for people to really be able to use them to effectively create new auth applications. We recently completed a new project to add those missing features and as part of that we created other commands that duplicated this functionality (oauth-app create etc). We created duplicate commands because we realized the features belonged in a different gRPC service and needed wanted more specific CLI commands.
There was a problem hiding this comment.
Got it, thanks for clarifying! In that case, this looks reasonable to me :)
viambot
added
safe to test
We now have other CLI commands that do the exact same thing but call our new apis (
oauth-appis the command)Removing these legacy commands in favor of the new ones. Will make sure docs are updated accordingly
this is part of a series of PRs to deprecate these protos and CLI commands: