RSDK-9672 Insulate grpc Status #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lia-viam
requested review from
njooma and
stuqdog
and removed request for
a team
stuqdog
approved these changes
Jan 8, 2025
| if (result.ok() || | ||
| (cancelled_by_handler && result.error_code() == ::grpc::StatusCode::CANCELLED)) { | ||
| if (result.ok() || (cancelled_by_handler && | ||
| client_helper_details::isStatusCancelled(result.error_code()))) { |
There was a problem hiding this comment.
(nit) delete blank newline here? jk formatting made it look weird on my computer, ignore!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes grpc status includes out of public headers
Note that service_helper has been moved to private for the time being--if there is demand we can re-publish it but it is not currently used anywhere and provides some awkward headaches for google header insulation