DATA-3446 Add exportTabularData to DataClient #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
requested changes
Dec 17, 2024
lib/src/app/data.dart
Outdated
| ) async* { | ||
| final interval = CaptureInterval(); | ||
| if (startTime != null) { | ||
| interval.start = Timestamp()..seconds = Int64((startTime.millisecondsSinceEpoch / 1000).floor()); |
There was a problem hiding this comment.
You can use the Timestamp.fromDateTime constructor to build these
lib/src/app/data.dart
Outdated
| ..resourceSubtype = resourceSubtype | ||
| ..methodName = methodName | ||
| ..interval = interval; | ||
| final responses = _dataClient.exportTabularData(request); |
There was a problem hiding this comment.
I believe this returns a stream, and you might be able to map this directly, instead of having to iterate and yield like you do below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new Data endpoint ExportTabularData to the flutter SDK.