Fix the pydantic logging validator #12420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent the validator from logging unused extra fields before object is validated by the pydantic validator. During the routing based on the request content where pydantic tries several classes for deserialization, this would result in spurious logs. Signed-off-by: Max de Bayser <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
DarkLight1337
approved these changes
Jan 25, 2025
|
Hmm, looks like this is causing a bunch of tests to fail. For example: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the validator from logging unused extra fields before object is validated by the pydantic validator.
During the routing based on the request content where pydantic tries several classes for deserialization, this would result in spurious logs.
For example, during in a request like this one:
vLLM would log
This is because pydantic tries to deserialize the JSON either as an
EmbeddingCompletionRequestor anEmbeddingChatRequest. During the validation of theEmbeddingChatRequestit shows this log because the field only exists inEmbeddingCompletionRequest. This could lead users to believe that theinputfield was ignored while processing the request.cc: @DarkLight1337 , @njhill (since you touched this code recently)