[Gecko Bug 1915589] Allow co-existing entrypTypes and buffered options in PerformanceObserver.observe() method. #50003
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rver.observe() method. It's allowed, but the buffered option is ignored. This is what Blink does [1], what WebKit does [2]. (Both code blocks are inside the else branch of if `has entryTypes`) The web-platform-test in this change was originally copied from buffered-flag-after-timeout.any.js and modified. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/timing/performance_observer.cc;l=264-273;drc=78780a188fe3c79fe815b170f4ea33e62ceb6e04 [2] https://searchfox.org/wubkat/rev/6c800745251d53d6486443d63b35828504446c5d/Source/WebCore/page/PerformanceObserver.cpp#90-100 [3] https://searchfox.org/mozilla-central/rev/e24277e20c492b4a785b4488af02cca062ec7c2c/testing/web-platform/tests/performance-timeline/buffered-flag-after-timeout.any.js Differential Revision: https://phabricator.services.mozilla.com/D233447 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1915589 gecko-commit: fb9d78b726556ac65a13e937410fe92f159b203f gecko-reviewers: sefeng
wpt-pr-bot
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's allowed, but the buffered option is ignored. This is what Blink
does [1], what WebKit does [2]. (Both code blocks are inside the else
branch of if
has entryTypes)The web-platform-test in this change was originally copied from
buffered-flag-after-timeout.any.js and modified.
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/timing/performance_observer.cc;l=264-273;drc=78780a188fe3c79fe815b170f4ea33e62ceb6e04
[2] https://searchfox.org/wubkat/rev/6c800745251d53d6486443d63b35828504446c5d/Source/WebCore/page/PerformanceObserver.cpp#90-100
[3] https://searchfox.org/mozilla-central/rev/e24277e20c492b4a785b4488af02cca062ec7c2c/testing/web-platform/tests/performance-timeline/buffered-flag-after-timeout.any.js
Differential Revision: https://phabricator.services.mozilla.com/D233447
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1915589
gecko-commit: fb9d78b726556ac65a13e937410fe92f159b203f
gecko-reviewers: sefeng