Make anchor positioning work when printing. #50014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was failing for a few reasons. Recent changes (2024), where a page fragmentainer (page area) is wrapped inside a page border box fragment inside a page container fragment was one reason. Another reason was that page fragments haven't yet been added to the fragment builder when handling OOFs (SetChildFragmentStorage() is used). Furthermore, we failed to collect any anchor references at all in StitchedAnchorQueryCollector if the containing block was the LayoutView, since the layout view is on the outside of the fragmentation context. Change-Id: I77db8113046cc51c2d6428c33cf09d5c2c343bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6135243 Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1404675}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6135243
branch
from
8d6d2b1 to
a126878
Compare
wpt-pr-bot
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was failing for a few reasons. Recent changes (2024), where a page
fragmentainer (page area) is wrapped inside a page border box fragment
inside a page container fragment was one reason. Another reason was that
page fragments haven't yet been added to the fragment builder when
handling OOFs (SetChildFragmentStorage() is used).
Furthermore, we failed to collect any anchor references at all in
StitchedAnchorQueryCollector if the containing block was the LayoutView,
since the layout view is on the outside of the fragmentation context.
Change-Id: I77db8113046cc51c2d6428c33cf09d5c2c343bce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6135243
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1404675}