#846: change minimum version of CryptoSwift dependency #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-callContractMethod Renamed callContractMethod to call for ReadOperation
…op-v4.0-up-to-date Chore/develop v4.0 up to date
…update Develop v4 update
Refactor createNewAccount function to be an internal function and remove unused password argument
* develop: (24 commits) refactor: random bytes generation; data and string extensions update (web3swift-team#791) encodeTopic bytes should accept hex string add more test for encodeTopic Trim Trailing Whitespace remove a force unwrap feat: enable encode Event and IETH.getLogs - isHardened check removed from createNewCustomChildAccount - linter warning fixed chore: trailing closure style for compactMap fix: used short notation for null checking fix: trimming / only if it's present as a prefix; using let for 'newPath'; - Test testAddressGeneration modified with hardcoded addresses chore: refactoring of createNewCustomChildAccount - bug with original pathAppendix fixed fix: createNewAccount always non-hardened derivation - Trailing Whitespace fixed in tests - not used code removed - small refactoring - closure style updated - pathAppendix declaration place changed - linter Trailing Whitespace Violation fixed - Grammar fixed - Removed prefix path from address generation ...
* develop: (24 commits) chore: added docs; new test for ABI.Element.Function; chore: Update Sources/Web3Core/EthereumNetwork/Request/APIRequest+Methods.swift chore: Update Sources/Web3Core/EthereumNetwork/Request/APIRequest+Methods.swift fix: testDecodeMulticallCopy fix: code spell chore: error messages updated chore: isHex string extension tests fix: isHex string extension function refactoring chore: avoiding try? in tests (try is more preffered) chore: missing space added chore: comment refactoring chore: docs refactoring chore: docs refactoring chore: code reordering chore: error message update update function documentation fix codespell resolve reviews suggestions add missing test contract bytecode fix eth method ... # Conflicts: # Tests/web3swiftTests/localTests/AdvancedABIv2Tests.swift # Tests/web3swiftTests/localTests/UncategorizedTests.swift
* chore: removed CocoaPods * chore: removing cocoapods support * chore: fixed linked to workflow file Signed-off-by: Jenea Vranceanu <[email protected]> * chore: swift badge colour change Signed-off-by: Jenea Vranceanu <[email protected]> * chore: added more examples to README.md Signed-off-by: Jenea Vranceanu <[email protected]> * chore: rephrasing, fixed typos README.md Signed-off-by: Jenea Vranceanu <[email protected]> * chore: Update README.md Signed-off-by: Jenea Vranceanu <[email protected]> * chore: hiding support badge in README.md Signed-off-by: Jenea Vranceanu <[email protected]> --------- Signed-off-by: Jenea Vranceanu <[email protected]>
The minimum version of 1.5.1 is too small. These changes resolve dependency conflicts that have the 'CryptoSwift' dependency within the SPM package
krsticmilos96
approved these changes
Sep 12, 2024
|
Could you please point it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum version of 1.5.1 is too small. These changes resolve dependency conflicts that have the 'CryptoSwift' dependency within the SPM package, e.g. 'SwiftLint' that uses the 'CryptoSwift' too
Summary of Changes
Fixes # (if applicable - add the number of issue this PR addresses)
Test Data or Screenshots
By submitting this pull request, you are confirming the following:
developbranch.