fixed issue 206, added tests #207
Conversation
| canvas.Save(); | ||
| canvas.DrawPicture(_svg.Picture); | ||
| canvas.Restore(); | ||
| lock (_svg.Locker) |
There was a problem hiding this comment.
this code fixes threading issue. There are two threads: render thread and a thread changing svg image. This code is 100% needed to fix the issue.
tests/Avalonia.Svg.Skia.UnitTests/Avalonia.Svg.Skia.UnitTests.csproj
Outdated
Show resolved
Hide resolved
|
@RomanKalachik CI is failing to run new unit tests |
It is not unit test. It is UI test. It reqires a CI runner wich can create windows. |
Avalonia provides headless unit testing compatible with Unit Testing |
https://docs.avaloniaui.net/docs/concepts/headless/headless-xunit |
Unfortunately, headless is not an option is this case.. Only a UI test with a real window and compositor reproduces the issue #206. |
I am afraid this might cause serious CI issues |
That's why UI test was moved to a separate project wich does not run by the current CI |
It was not intentional, will correct later today |
wieslawsoltes
force-pushed
the
master
branch
2 times, most recently
from
ef199e7 to
ea187d7
Compare
|
Super-seeded by #212 |
No description provided.