Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @preact/preset-vite to version 2.9.4 #12950

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Marabyte
Copy link

@Marabyte Marabyte commented Jan 9, 2025

Changes

Testing

In examples/frameworks-preact linked @preact/preset-vite to the workspace and manually tested Astro with Preact

Docs

No need to update docs

Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 557b8bb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: preact Related to Preact (scope) pkg: integration Related to any renderer integration (scope) labels Jan 9, 2025
@ascorbic
Copy link
Contributor

Thanks. Can you look into why the tests are failing?

@Marabyte
Copy link
Author

Thanks. Can you look into why the tests are failing?

Yeah, taking a look now!

@bluwy
Copy link
Member

bluwy commented Jan 10, 2025

It's failing because of this

"@preact/preset-vite", // v2.8.3 starts to use Vite's esbuild for perf, but this conflicts with the react plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants