Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Gradle repositories #13307

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Unify Gradle repositories #13307

merged 2 commits into from
Jan 14, 2025

Conversation

wzieba
Copy link
Contributor

@wzieba wzieba commented Jan 14, 2025

Description

This PR unifies configuration of repositories for modules in the project via dependencyResolutionManagement. It's already used in WP/JP app without any issues: wordpress-mobile/WordPress-Android@c009a79 and I've recently, by an accident, spotted the discussion (#13052 (comment)) about this issue in one of the PRs.

Lastly, this will help with #13304.

Testing information

A green light from CI is completely fine 👍

The tests that have been performed

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

This way, repositories for dependencies of all modules are configured from a single place, reducing repetitions.
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit107d6ff
Direct Downloadwoocommerce-wear-prototype-build-pr13307-107d6ff.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit107d6ff
Direct Downloadwoocommerce-prototype-build-pr13307-107d6ff.apk

@wzieba wzieba added type: enhancement A request for an enhancement. category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. labels Jan 14, 2025
@wzieba wzieba added this to the 21.5 milestone Jan 14, 2025
@wzieba wzieba marked this pull request as ready for review January 14, 2025 16:06
Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this @wzieba ❤️

@hichamboushaba hichamboushaba merged commit 888b2e9 into trunk Jan 14, 2025
20 checks passed
@hichamboushaba hichamboushaba deleted the unify_gradle_repositories branch January 14, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants