RSDK-9670: remove RobotService_ #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lia-viam
requested review from
njooma,
purplenicole730 and
stuqdog
and removed request for
a team
stuqdog
approved these changes
Jan 8, 2025
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| #include <viam/sdk/components/camera.hpp> | |||
| #include <viam/sdk/robot/client.hpp> | |||
| #include <viam/sdk/robot/service.hpp> | |||
|
|
|||
There was a problem hiding this comment.
(nit) should delete this newline so the viam/sdk imports are grouped together
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| #include <viam/sdk/components/generic.hpp> | |||
| #include <viam/sdk/robot/client.hpp> | |||
| #include <viam/sdk/robot/service.hpp> | |||
|
|
|||
There was a problem hiding this comment.
(nit) should delete this newline so the viam/sdk imports are grouped together
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| #include <viam/sdk/components/motor.hpp> | |||
| #include <viam/sdk/robot/client.hpp> | |||
| #include <viam/sdk/robot/service.hpp> | |||
|
|
|||
There was a problem hiding this comment.
(nit) should delete this newline so the viam/sdk imports are grouped together
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| #include <viam/sdk/components/motor.hpp> | |||
| #include <viam/sdk/robot/client.hpp> | |||
| #include <viam/sdk/robot/service.hpp> | |||
|
|
|||
There was a problem hiding this comment.
(nit) should delete this newline so the viam/sdk imports are grouped together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is currently unused except for in
MockRobotService, so we are letting it be absorbed intoMockRobotService. If there is demand we can see about reinstatingRobotService_possibly as an example class.